ref(layout): use Layout.Page on alerts#111642
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| </Layout.Side> | ||
| </Layout.Body> | ||
| </PageFiltersContainer> | ||
| </Layout.Page> |
There was a problem hiding this comment.
Early returns missing Layout.Page wrapper
Low Severity
The main return path at line 385 is now wrapped in Layout.Page (rendering inside a <main> element), but the three early returns — loading state (lines 253–260), error state (lines 263–268), and missing project (lines 271–276) — are not wrapped. This causes the page layout structure to inconsistently switch between having and not having a <main> element depending on the component's data-fetching state, which can produce layout shifts when transitioning from loading to loaded.
Additional Locations (1)
There was a problem hiding this comment.
this is a valid observation, but early returns for loading/error states are intentionally not wrapped in Layout.Page. This is consistent with other pages in the codebase (e.g., issues list, metric alert details, uptime details). The Layout.Page wrapper is only applied to the main content render path.
Wrap the issue alert rule details page with Layout.Page, consistent with the other alert pages updated in the prior commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
priscilawebdev
force-pushed
the
JonasBa/ref/layout-page-alerts
branch
from
0ae38cd to
6c03a42
Compare
priscilawebdev
left a comment
priscilawebdev
left a comment
There was a problem hiding this comment.
manually checked the changes and they look good.
2 participants
Wraps non-compliant routes in the alerts area with Layout.Page.
Part of the Layout.Page audit remediation.
Changes
static/app/views/alerts/list/incidents/index.tsx— wraprenderBody()return andrenderDisabled()inLayout.Pagestatic/app/views/alerts/list/rules/alertRulesList.tsx— wrapPageFiltersContainerblock inLayout.Pagestatic/app/views/alerts/create.tsx— replace outerFragmentwithLayout.Pagestatic/app/views/alerts/edit.tsx— replace outerFragmentwithLayout.PageAffected routes
/organizations/:orgId/alerts//organizations/:orgId/alerts/rules//organizations/:orgId/alerts/:projectId/new//organizations/:orgId/alerts/crons-rules/:projectId/:monitorSlug/Verification
<main>element